fix validation error

models/Booking.js

@@ -12,20 +12,31 @@ const bookingSchema = new mongoose.Schema({
     required: true,
     unique: true
   },
-  
+
   // Guest information
   guest: {
     type: mongoose.Schema.Types.ObjectId,
     ref: 'Guest',
     required: true
   },
-  
+
   // Room and dates
   room: {
     type: mongoose.Schema.Types.ObjectId,
     ref: 'Room',
-    required: true
+    required: false 
   },
+
+  roomCategoryId: {
+    type: mongoose.Schema.Types.ObjectId,
+    ref: 'RoomCategory',
+    required: false
+  },
+  requestedRoomType: {
+    type: String,
+    maxlength: 200
+  },
+
   checkInDate: {
     type: Date,
     required: true
@@ -34,7 +45,7 @@ const bookingSchema = new mongoose.Schema({
     type: Date,
     required: true
   },
-  
+
   // Guest details
   numberOfGuests: {
     adults: {
@@ -48,7 +59,7 @@ const bookingSchema = new mongoose.Schema({
       min: 0
     }
   },
-  
+
   // Pricing
   roomRate: {
     type: Number,
@@ -78,7 +89,7 @@ const bookingSchema = new mongoose.Schema({
     type: Number,
     required: true
   },
-  
+
   // Payment information
   paymentStatus: {
     type: String,
@@ -90,14 +101,14 @@ const bookingSchema = new mongoose.Schema({
     enum: ['Credit Card', 'Debit Card', 'Bank Transfer', 'Cash', 'Online Payment']
   },
   stripePaymentIntentId: String,
-  
+
   // Booking status
   status: {
     type: String,
     enum: ['Pending', 'Confirmed', 'Checked In', 'Checked Out', 'Cancelled', 'No Show'],
     default: 'Pending'
   },
-  
+
   // Special requests and notes
   specialRequests: {
     type: String,
@@ -107,7 +118,7 @@ const bookingSchema = new mongoose.Schema({
     type: String,
     maxlength: 1000
   },
-  
+
   // Check-in/out details
   actualCheckInTime: Date,
   actualCheckOutTime: Date,
@@ -119,18 +130,18 @@ const bookingSchema = new mongoose.Schema({
     type: Boolean,
     default: false
   },
-  
+
   // Booking source
   bookingSource: {
     type: String,
     enum: ['Direct', 'Booking.com', 'Expedia', 'Trip.com', 'Phone', 'Walk-in', 'Travel Agent'],
     default: 'Direct'
   },
-  
+
   // External system IDs
   operaBookingId: String,
   externalBookingId: String, // ID from booking platforms
-  
+
   // Cancellation
   cancellationReason: String,
   cancellationDate: Date,
@@ -142,7 +153,7 @@ const bookingSchema = new mongoose.Schema({
     type: Number,
     default: 0
   },
-  
+
   // Communication
   emailConfirmationSent: {
     type: Boolean,
@@ -152,7 +163,7 @@ const bookingSchema = new mongoose.Schema({
     type: Boolean,
     default: false
   },
-  
+
   // Additional services
   addOns: [{
     service: String,
@@ -161,7 +172,7 @@ const bookingSchema = new mongoose.Schema({
     unitPrice: Number,
     totalPrice: Number
   }],
-  
+
   // Group booking
   isGroupBooking: {
     type: Boolean,
@@ -169,7 +180,7 @@ const bookingSchema = new mongoose.Schema({
   },
   groupSize: Number,
   groupLeader: String,
-  
+
   // Loyalty program
   loyaltyPointsEarned: {
     type: Number,
@@ -213,7 +224,7 @@ bookingSchema.pre('validate', function(next) {
     const random = Math.floor(100000 + Math.random() * 900000);
     this.bookingNumber = `OVH${year}${random}`;
   }
-  
+
   if (!this.confirmationCode) {
     // Generate confirmation code: 8 character alphanumeric
     const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
@@ -223,13 +234,13 @@ bookingSchema.pre('validate', function(next) {
     }
     this.confirmationCode = code;
   }
-  
+
   // Calculate number of nights if not set
   if (!this.numberOfNights && this.checkInDate && this.checkOutDate) {
     const diffTime = Math.abs(this.checkOutDate - this.checkInDate);
     this.numberOfNights = Math.ceil(diffTime / (1000 * 60 * 60 * 24));
   }
-  
+
   next();
 });
 
@@ -265,9 +276,9 @@ bookingSchema.methods.canBeCancelled = function() {
   const now = new Date();
   const checkInDate = new Date(this.checkInDate);
   const hoursUntilCheckIn = (checkInDate - now) / (1000 * 60 * 60);
-  
+
   return (
-    this.status === 'Confirmed' && 
+    this.status === 'Confirmed' &&
     hoursUntilCheckIn > 24 // Can cancel up to 24 hours before check-in
   );
 };
@@ -277,7 +288,7 @@ bookingSchema.methods.calculateCancellationFee = function() {
   const now = new Date();
   const checkInDate = new Date(this.checkInDate);
   const hoursUntilCheckIn = (checkInDate - now) / (1000 * 60 * 60);
-  
+
   if (hoursUntilCheckIn > 48) {
     return 0; // Free cancellation
   } else if (hoursUntilCheckIn > 24) {

routes/bookings.js

@@ -10,6 +10,50 @@ const stripe = require('stripe')(process.env.STRIPE_SECRET_KEY);
 const sendEmail = require('../utils/sendEmail');
 const logger = require('../utils/logger');
 
+const escapeRegex = (s = '') => String(s).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+
+async function resolveRoomFromCategory({ roomCategoryId, requestedRoomType, checkIn, checkOut, totalGuests }) {
+  const or = [];
+
+  if (roomCategoryId) {
+    or.push(
+      { category: roomCategoryId },
+      { categoryId: roomCategoryId },
+      { roomCategory: roomCategoryId },
+      { roomCategoryId: roomCategoryId },
+      { typeId: roomCategoryId }
+    );
+  }
+
+  if (requestedRoomType) {
+    const rx = new RegExp(`^${escapeRegex(requestedRoomType)}$`, 'i');
+    or.push(
+      { type: rx },
+      { roomType: rx },
+      { categoryName: rx },
+      { name: rx }
+    );
+  }
+
+  if (or.length === 0) return null;
+
+  const candidates = await Room.find({
+    isActive: true,
+    $or: or
+  }).limit(50);
+
+  for (const room of candidates) {
+    try {
+      if (room.maxOccupancy != null && room.maxOccupancy < totalGuests) continue;
+      const ok = await room.isAvailable(checkIn, checkOut);
+      if (ok) return room;
+    } catch (e) {
+      // ignore and try next
+    }
+  }
+
+  return null;
+}
 
 // @route   POST /api/bookings/request
 // @desc    Create a booking request (no online payment)
@@ -19,7 +63,21 @@ router.post('/request', [
   body('guestInfo.lastName').notEmpty().withMessage('Last name is required'),
   body('guestInfo.email').isEmail().withMessage('Valid email is required'),
   body('guestInfo.phone').notEmpty().withMessage('Phone number is required'),
-  body('roomId').isMongoId().withMessage('Valid room ID is required'),
+
+  //  accept roomId OR roomCategoryId / requestedRoomType
+  body('roomId').optional().isMongoId().withMessage('Valid room ID is required'),
+  body('roomCategoryId').optional().isMongoId().withMessage('Valid room category ID is required'),
+  body('requestedRoomType').optional().isString().isLength({ max: 200 }),
+  body('roomCategory').optional().isString().isLength({ max: 200 }),
+
+  body().custom((_, { req }) => {
+    if (req.body.roomId) return true;
+    if (req.body.roomCategoryId) return true;
+    if (req.body.requestedRoomType) return true;
+    if (req.body.roomCategory) return true;
+    throw new Error('roomId or roomCategoryId/requestedRoomType is required');
+  }),
+
   body('checkInDate').isISO8601().withMessage('Valid check-in date is required'),
   body('checkOutDate').isISO8601().withMessage('Valid check-out date is required'),
   body('numberOfGuests.adults').isInt({ min: 1 }).withMessage('At least 1 adult required'),
@@ -35,7 +93,17 @@ router.post('/request', [
       });
     }
 
-    const { guestInfo, roomId, checkInDate, checkOutDate, numberOfGuests, specialRequests } = req.body;
+    const {
+      guestInfo,
+      roomId,
+      roomCategoryId,
+      roomCategory,
+      requestedRoomType,
+      checkInDate,
+      checkOutDate,
+      numberOfGuests,
+      specialRequests
+    } = req.body;
 
     const checkIn = new Date(checkInDate);
     const checkOut = new Date(checkOutDate);
@@ -47,25 +115,48 @@ router.post('/request', [
       return res.status(400).json({ success: false, message: 'Check-in date cannot be in the past' });
     }
 
-    const room = await Room.findById(roomId);
-    if (!room || !room.isActive) {
-      return res.status(404).json({ success: false, message: 'Room not found' });
-    }
-
     const totalGuests = Number(numberOfGuests.adults) + Number(numberOfGuests.children || 0);
-    if (room.maxOccupancy < totalGuests) {
-      return res.status(400).json({
-        success: false,
-        message: `Room can accommodate maximum ${room.maxOccupancy} guests`
-      });
-    }
 
-    const isAvailable = await room.isAvailable(checkIn, checkOut);
-    if (!isAvailable) {
-      return res.status(400).json({
-        success: false,
-        message: 'Room is not available for the selected dates'
+    //  If roomId provided, keep old behavior
+    let room = null;
+    if (roomId) {
+      room = await Room.findById(roomId);
+      if (!room || !room.isActive) {
+        return res.status(404).json({ success: false, message: 'Room not found' });
+      }
+
+      if (room.maxOccupancy < totalGuests) {
+        return res.status(400).json({
+          success: false,
+          message: `Room can accommodate maximum ${room.maxOccupancy} guests`
+        });
+      }
+
+      const isAvailable = await room.isAvailable(checkIn, checkOut);
+      if (!isAvailable) {
+        return res.status(400).json({
+          success: false,
+          message: 'Room is not available for the selected dates'
+        });
+      }
+    } else {
+      //  No roomId => try to resolve an actual room from category/type
+      const typeName = requestedRoomType || roomCategory || null;
+      room = await resolveRoomFromCategory({
+        roomCategoryId,
+        requestedRoomType: typeName,
+        checkIn,
+        checkOut,
+        totalGuests
       });
+
+      // If we found a room, enforce occupancy like before
+      if (room && room.maxOccupancy != null && room.maxOccupancy < totalGuests) {
+        return res.status(400).json({
+          success: false,
+          message: `Room can accommodate maximum ${room.maxOccupancy} guests`
+        });
+      }
     }
 
     // Find or create guest
@@ -80,14 +171,23 @@ router.post('/request', [
 
     // Pricing
     const numberOfNights = Math.ceil((checkOut - checkIn) / (1000 * 60 * 60 * 24));
-    const roomRate = room.currentPrice;
+
+    // If room exists => use its currentPrice (old behavior)
+    // If room doesn't exist => set roomRate to 0 (or you can later adjust manually in admin)
+    const roomRate = room ? Number(room.currentPrice || 0) : 0;
+
     const subtotal = roomRate * numberOfNights;
     const taxes = subtotal * 0.12;
     const totalAmount = subtotal + taxes;
 
     const booking = new Booking({
       guest: guest._id,
-      room: roomId,
+      room: room ? room._id : undefined,
+
+      //  store category/type for category-only requests
+      roomCategoryId: room ? undefined : (roomCategoryId || undefined),
+      requestedRoomType: room ? undefined : (requestedRoomType || roomCategory || undefined),
+
       checkInDate: checkIn,
       checkOutDate: checkOut,
       numberOfGuests,
@@ -155,7 +255,7 @@ router.post('/', [
 
     const checkIn = new Date(checkInDate);
     const checkOut = new Date(checkOutDate);
-    
+
     // Validate dates
     if (checkIn >= checkOut) {
       return res.status(400).json({
@@ -163,7 +263,7 @@ router.post('/', [
         message: 'Check-out date must be after check-in date'
       });
     }
-    
+
     if (checkIn < new Date()) {
       return res.status(400).json({
         success: false,
@@ -284,7 +384,7 @@ router.post('/', [
             room: room
           }
         });
-        
+
         booking.emailConfirmationSent = true;
         await booking.save();
       } catch (emailError) {
@@ -294,8 +394,8 @@ router.post('/', [
 
     res.status(201).json({
       success: true,
-      message: paymentIntent.status === 'succeeded' 
-        ? 'Booking confirmed successfully' 
+      message: paymentIntent.status === 'succeeded'
+        ? 'Booking confirmed successfully'
         : 'Booking created, payment processing',
       data: {
         booking,
@@ -324,7 +424,7 @@ router.get('/:bookingNumber', async (req, res) => {
     const { confirmationCode } = req.query;
 
     let booking;
-    
+
     // If confirmation code provided, allow public access
     if (confirmationCode) {
       booking = await Booking.findOne({
@@ -332,7 +432,6 @@ router.get('/:bookingNumber', async (req, res) => {
         confirmationCode
       }).populate(['guest', 'room']);
     } else {
-      // Otherwise require authentication (implement auth middleware check here)
       booking = await Booking.findOne({ bookingNumber })
         .populate(['guest', 'room']);
     }
@@ -486,13 +585,13 @@ router.get('/', adminAuth, async (req, res) => {
 
     // Build filter
     let filter = {};
-    
+
     if (status) filter.status = status;
     if (guestEmail) {
       const guest = await Guest.findOne({ email: guestEmail });
       if (guest) filter.guest = guest._id;
     }
-    
+
     if (checkInDate || checkOutDate) {
       filter.checkInDate = {};
       if (checkInDate) filter.checkInDate.$gte = new Date(checkInDate);
@@ -501,7 +600,7 @@ router.get('/', adminAuth, async (req, res) => {
 
     // Build aggregation pipeline for room type filter
     let aggregationPipeline = [{ $match: filter }];
-    
+
     if (roomType) {
       aggregationPipeline.push(
         {
@@ -523,7 +622,7 @@ router.get('/', adminAuth, async (req, res) => {
     // Add pagination and sorting
     const sortOptions = {};
     sortOptions[sortBy] = sortOrder === 'desc' ? -1 : 1;
-    
+
     aggregationPipeline.push(
       { $sort: sortOptions },
       { $skip: (parseInt(page) - 1) * parseInt(limit) },
@@ -544,12 +643,9 @@ router.get('/', adminAuth, async (req, res) => {
           as: 'room'
         }
       },
-      {
-        $unwind: '$guest'
-      },
-      {
-        $unwind: '$room'
-      }
+      { $unwind: '$guest' },
+      // ✅ preserve bookings even if room is null
+      { $unwind: { path: '$room', preserveNullAndEmptyArrays: true } }
     );
 
     const [bookings, totalCount] = await Promise.all([
@@ -596,6 +692,14 @@ router.put('/:id/checkin', adminAuth, async (req, res) => {
       });
     }
 
+    //  guard if no room assigned
+    if (!booking.room) {
+      return res.status(400).json({
+        success: false,
+        message: 'Booking has no room assigned'
+      });
+    }
+
     if (booking.status !== 'Confirmed') {
       return res.status(400).json({
         success: false,
@@ -603,12 +707,10 @@ router.put('/:id/checkin', adminAuth, async (req, res) => {
       });
     }
 
-    // Update booking status
     booking.status = 'Checked In';
     booking.actualCheckInTime = new Date();
     await booking.save();
 
-    // Update room status
     const room = await Room.findById(booking.room._id);
     room.status = 'Occupied';
     await room.save();
@@ -642,6 +744,14 @@ router.put('/:id/checkout', adminAuth, async (req, res) => {
       });
     }
 
+    //  guard if no room assigned
+    if (!booking.room) {
+      return res.status(400).json({
+        success: false,
+        message: 'Booking has no room assigned'
+      });
+    }
+
     if (booking.status !== 'Checked In') {
       return res.status(400).json({
         success: false,
@@ -649,12 +759,10 @@ router.put('/:id/checkout', adminAuth, async (req, res) => {
       });
     }
 
-    // Update booking status
     booking.status = 'Checked Out';
     booking.actualCheckOutTime = new Date();
     await booking.save();
 
-    // Update room status
     const room = await Room.findById(booking.room._id);
     room.status = 'Available';
     room.cleaningStatus = 'Dirty';
@@ -681,13 +789,12 @@ router.put('/:id/checkout', adminAuth, async (req, res) => {
 router.get('/analytics/revenue', adminAuth, async (req, res) => {
   try {
     const { startDate, endDate, groupBy = 'day' } = req.query;
-    
+
     const start = startDate ? new Date(startDate) : new Date(Date.now() - 30 * 24 * 60 * 60 * 1000);
     const end = endDate ? new Date(endDate) : new Date();
 
     const revenueData = await Booking.generateRevenueReport(start, end);
-    
-    // Calculate total metrics
+
     const totalRevenue = revenueData.reduce((sum, day) => sum + day.totalRevenue, 0);
     const totalBookings = revenueData.reduce((sum, day) => sum + day.bookingsCount, 0);
     const averageBookingValue = totalBookings > 0 ? totalRevenue / totalBookings : 0;

routes/media.js

@@ -2,24 +2,21 @@ const express = require('express');
 const router = express.Router();
 const multer = require('multer');
 const path = require('path');
-const fsNative = require('fs');
 const fs = require('fs').promises;
-
 const Media = require('../models/Media');
 const adminAuth = require('../middleware/adminAuth');
 
-// =======================
-// Config (LOCAL + PROD)
-// =======================
-const UPLOAD_DIR = process.env.UPLOAD_DIR
-  ? path.resolve(process.env.UPLOAD_DIR)
-  : path.resolve(__dirname, '..', 'uploads'); // local fallback
+const isProd = process.env.NODE_ENV === 'production';
 
-const PUBLIC_BASE = process.env.UPLOAD_PUBLIC_URL || '/uploads';
-const MEDIA_ROOT = process.env.MEDIA_SUBDIR || 'images';
+// In dev: oldvine_cms/client/public/images
+const devImagesRoot = path.join(__dirname, '../../client/public/images');
 
-// Ensure upload directories exist
-const ensureUploadDir = async (dir) => {
+// On server: nginx serves /images from /var/www/oldvine/images (recommended)
+const imagesRoot =
+  process.env.IMAGES_DIR ||
+  (isProd ? '/var/www/oldvine/images' : devImagesRoot);
+
+const ensureDir = async (dir) => {
   try {
     await fs.access(dir);
   } catch {
@@ -27,26 +24,23 @@ const ensureUploadDir = async (dir) => {
   }
 };
 
-const sanitizeFolder = (folder) => {
-  let f = String(folder || 'general').trim();
-  // allow a-z0-9 _ - and slashes for nested folders
-  f = f.replace(/[^a-z0-9/_-]/gi, '');
-  // prevent traversal
-  while (f.includes('..')) f = f.replace(/\.\./g, '');
-  f = f.replace(/^\/+|\/+$/g, '');
-  return f || 'general';
-};
+const safeFolder = (s) =>
+  String(s || 'general')
+    .toLowerCase()
+    .replace(/[^a-z0-9]/g, '-')
+    .replace(/-+/g, '-')
+    .replace(/^-|-$/g, '') || 'general';
 
 // Configure multer storage
 const storage = multer.diskStorage({
   destination: async (req, file, cb) => {
     try {
-      const folderSafe = sanitizeFolder(req.body.folder);
-      const uploadPath = path.join(UPLOAD_DIR, MEDIA_ROOT, folderSafe);
-      await ensureUploadDir(uploadPath);
+      const folder = safeFolder(req.body.folder || 'general');
+      const uploadPath = path.join(imagesRoot, folder);
+      await ensureDir(uploadPath);
       cb(null, uploadPath);
-    } catch (e) {
-      cb(e);
+    } catch (err) {
+      cb(err);
     }
   },
   filename: (req, file, cb) => {
@@ -58,13 +52,12 @@ const storage = multer.diskStorage({
       .replace(/[^a-z0-9]/g, '-')
       .replace(/-+/g, '-')
       .replace(/^-|-$/g, '');
-    cb(null, (basename || 'file') + '-' + uniqueSuffix + ext.toLowerCase());
+    cb(null, `${basename || 'media'}-${uniqueSuffix}${ext.toLowerCase()}`);
   },
 });
 
-// File filter
 const fileFilter = (req, file, cb) => {
-  const allowedMimeTypes = [
+  const allowed = [
     'image/jpeg',
     'image/jpg',
     'image/png',
@@ -75,58 +68,37 @@ const fileFilter = (req, file, cb) => {
     'video/quicktime',
     'application/pdf',
   ];
-
-  if (allowedMimeTypes.includes(file.mimetype)) {
-    cb(null, true);
-  } else {
-    cb(new Error('Invalid file type. Only images, videos, and PDFs are allowed.'), false);
-  }
+  if (allowed.includes(file.mimetype)) return cb(null, true);
+  cb(new Error('Invalid file type. Only images, videos, and PDFs are allowed.'), false);
 };
 
 const upload = multer({
   storage,
   fileFilter,
-  limits: {
-    fileSize: 10 * 1024 * 1024, // 10MB limit
-  },
+  limits: { fileSize: 10 * 1024 * 1024 },
 });
 
-// @route   POST /api/media/upload
-// @desc    Upload media file
-// @access  Private (Admin)
+// POST /api/media/upload
 router.post('/upload', adminAuth, upload.single('file'), async (req, res) => {
   try {
-    if (!req.file) {
-      return res.status(400).json({
-        success: false,
-        message: 'No file uploaded',
-      });
-    }
+    if (!req.file) return res.status(400).json({ success: false, message: 'No file uploaded' });
 
-    const folderSafe = sanitizeFolder(req.body.folder);
+    const folder = safeFolder(req.body.folder || 'general');
     const { alt, caption, description, tags } = req.body;
 
-    // Determine media type
     let mediaType = 'other';
-    if (req.file.mimetype.startsWith('image/')) {
-      mediaType = 'image';
-    } else if (req.file.mimetype.startsWith('video/')) {
-      mediaType = 'video';
-    } else if (req.file.mimetype === 'application/pdf') {
-      mediaType = 'document';
-    }
+    if (req.file.mimetype.startsWith('image/')) mediaType = 'image';
+    else if (req.file.mimetype.startsWith('video/')) mediaType = 'video';
+    else if (req.file.mimetype === 'application/pdf') mediaType = 'document';
 
-    const url = `${PUBLIC_BASE}/${MEDIA_ROOT}/${folderSafe}/${req.file.filename}`;
-
-    // Create media record
     const media = new Media({
       filename: req.file.filename,
       originalName: req.file.originalname,
-      url,
+      url: `/images/${folder}/${req.file.filename}`,
       mimeType: req.file.mimetype,
       size: req.file.size,
       type: mediaType,
-      folder: folderSafe,
+      folder,
       alt,
       caption,
       description,
@@ -136,55 +108,37 @@ router.post('/upload', adminAuth, upload.single('file'), async (req, res) => {
 
     await media.save();
 
-    res.status(201).json({
-      success: true,
-      message: 'File uploaded successfully',
-      data: { media },
-    });
+    res.status(201).json({ success: true, message: 'File uploaded successfully', data: { media } });
   } catch (error) {
     console.error('Upload error:', error);
-    res.status(500).json({
-      success: false,
-      message: error.message || 'Error uploading file',
-    });
+    res.status(500).json({ success: false, message: error.message || 'Error uploading file' });
   }
 });
 
-// @route   POST /api/media/upload-multiple
-// @desc    Upload multiple media files
-// @access  Private (Admin)
+// POST /api/media/upload-multiple
 router.post('/upload-multiple', adminAuth, upload.array('files', 10), async (req, res) => {
   try {
     if (!req.files || req.files.length === 0) {
-      return res.status(400).json({
-        success: false,
-        message: 'No files uploaded',
-      });
+      return res.status(400).json({ success: false, message: 'No files uploaded' });
     }
 
-    const folderSafe = sanitizeFolder(req.body.folder);
+    const folder = safeFolder(req.body.folder || 'general');
     const mediaRecords = [];
 
     for (const file of req.files) {
       let mediaType = 'other';
-      if (file.mimetype.startsWith('image/')) {
-        mediaType = 'image';
-      } else if (file.mimetype.startsWith('video/')) {
-        mediaType = 'video';
-      } else if (file.mimetype === 'application/pdf') {
-        mediaType = 'document';
-      }
-
-      const url = `${PUBLIC_BASE}/${MEDIA_ROOT}/${folderSafe}/${file.filename}`;
+      if (file.mimetype.startsWith('image/')) mediaType = 'image';
+      else if (file.mimetype.startsWith('video/')) mediaType = 'video';
+      else if (file.mimetype === 'application/pdf') mediaType = 'document';
 
       const media = new Media({
         filename: file.filename,
         originalName: file.originalname,
-        url,
+        url: `/images/${folder}/${file.filename}`,
         mimeType: file.mimetype,
         size: file.size,
         type: mediaType,
-        folder: folderSafe,
+        folder,
         uploadedBy: req.admin.id,
       });
 
@@ -199,16 +153,11 @@ router.post('/upload-multiple', adminAuth, upload.array('files', 10), async (req
     });
   } catch (error) {
     console.error('Multiple upload error:', error);
-    res.status(500).json({
-      success: false,
-      message: error.message || 'Error uploading files',
-    });
+    res.status(500).json({ success: false, message: error.message || 'Error uploading files' });
   }
 });
 
-// @route   GET /api/media
-// @desc    Get all media
-// @access  Private (Admin)
+// GET /api/media
 router.get('/', adminAuth, async (req, res) => {
   try {
     const { folder, type, page = 1, limit = 50 } = req.query;
@@ -228,57 +177,29 @@ router.get('/', adminAuth, async (req, res) => {
 
     res.json({
       success: true,
-      data: {
-        media,
-        pagination: {
-          page: parseInt(page, 10),
-          limit: parseInt(limit, 10),
-          total,
-          pages: Math.ceil(total / limit),
-        },
-      },
+      data: { media, pagination: { page: parseInt(page, 10), limit: parseInt(limit, 10), total, pages: Math.ceil(total / limit) } },
     });
   } catch (error) {
     console.error('Get media error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error fetching media',
-    });
+    res.status(500).json({ success: false, message: 'Error fetching media' });
   }
 });
 
-// @route   GET /api/media/search
-// @desc    Search media
-// @access  Private (Admin)
+// GET /api/media/search
 router.get('/search', adminAuth, async (req, res) => {
   try {
     const { q, folder, type, limit = 50 } = req.query;
-
-    if (!q) {
-      return res.status(400).json({
-        success: false,
-        message: 'Search query is required',
-      });
-    }
+    if (!q) return res.status(400).json({ success: false, message: 'Search query is required' });
 
     const media = await Media.search(q, { folder, type, limit: parseInt(limit, 10) });
-
-    res.json({
-      success: true,
-      data: { media },
-    });
+    res.json({ success: true, data: { media } });
   } catch (error) {
     console.error('Search media error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error searching media',
-    });
+    res.status(500).json({ success: false, message: 'Error searching media' });
   }
 });
 
-// @route   PUT /api/media/:id
-// @desc    Update media metadata
-// @access  Private (Admin)
+// PUT /api/media/:id
 router.put('/:id', adminAuth, async (req, res) => {
   try {
     const { id } = req.params;
@@ -289,107 +210,51 @@ router.put('/:id', adminAuth, async (req, res) => {
     if (caption !== undefined) updateFields.caption = caption;
     if (description !== undefined) updateFields.description = description;
     if (tags !== undefined) updateFields.tags = tags;
-    if (folder !== undefined) updateFields.folder = sanitizeFolder(folder);
+    if (folder !== undefined) updateFields.folder = safeFolder(folder);
 
     const media = await Media.findByIdAndUpdate(id, { $set: updateFields }, { new: true, runValidators: true });
+    if (!media) return res.status(404).json({ success: false, message: 'Media not found' });
 
-    if (!media) {
-      return res.status(404).json({
-        success: false,
-        message: 'Media not found',
-      });
-    }
-
-    res.json({
-      success: true,
-      message: 'Media updated successfully',
-      data: { media },
-    });
+    res.json({ success: true, message: 'Media updated successfully', data: { media } });
   } catch (error) {
     console.error('Update media error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error updating media',
-    });
+    res.status(500).json({ success: false, message: 'Error updating media' });
   }
 });
 
-const safeResolveInside = (base, rel) => {
-  const baseAbs = path.resolve(base);
-  const targetAbs = path.resolve(baseAbs, rel);
-  if (!targetAbs.startsWith(baseAbs + path.sep)) return null;
-  return targetAbs;
-};
-
-// @route   DELETE /api/media/:id
-// @desc    Delete media file
-// @access  Private (Admin)
+// DELETE /api/media/:id
 router.delete('/:id', adminAuth, async (req, res) => {
   try {
     const { id } = req.params;
-
     const media = await Media.findById(id);
+    if (!media) return res.status(404).json({ success: false, message: 'Media not found' });
 
-    if (!media) {
-      return res.status(404).json({
-        success: false,
-        message: 'Media not found',
-      });
-    }
+    // media.url example: /images/general/file.jpg
+    const rel = media.url.replace(/^\/images\//, '');
+    const filePath = path.join(imagesRoot, rel);
 
-    // Delete file from filesystem (only if inside UPLOAD_DIR)
     try {
-      const url = String(media.url || '');
-      let rel = null;
-
-      if (url.startsWith(PUBLIC_BASE + '/')) {
-        rel = url.slice((PUBLIC_BASE + '/').length);
-      } else if (url.startsWith('/uploads/')) {
-        rel = url.slice('/uploads/'.length);
-      }
-
-      if (rel) {
-        const filePath = safeResolveInside(UPLOAD_DIR, rel);
-        if (filePath && fsNative.existsSync(filePath)) {
-          await fs.unlink(filePath);
-        }
-      }
+      await fs.unlink(filePath);
     } catch (err) {
       console.error('Error deleting file:', err);
     }
 
     await Media.findByIdAndDelete(id);
-
-    res.json({
-      success: true,
-      message: 'Media deleted successfully',
-    });
+    res.json({ success: true, message: 'Media deleted successfully' });
   } catch (error) {
     console.error('Delete media error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error deleting media',
-    });
+    res.status(500).json({ success: false, message: 'Error deleting media' });
   }
 });
 
-// @route   GET /api/media/folders/list
-// @desc    Get list of all folders
-// @access  Private (Admin)
+// GET /api/media/folders/list
 router.get('/folders/list', adminAuth, async (req, res) => {
   try {
     const folders = await Media.distinct('folder');
-
-    res.json({
-      success: true,
-      data: { folders },
-    });
+    res.json({ success: true, data: { folders } });
   } catch (error) {
     console.error('Get folders error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error fetching folders',
-    });
+    res.status(500).json({ success: false, message: 'Error fetching folders' });
   }
 });
 

routes/upload.js

@@ -6,115 +6,101 @@ const fs = require('fs');
 const sharp = require('sharp');
 const adminAuth = require('../middleware/adminAuth');
 
-// =======================
-// Config (LOCAL + PROD)
-// =======================
-const UPLOAD_DIR = process.env.UPLOAD_DIR
-  ? path.resolve(process.env.UPLOAD_DIR)
-  : path.resolve(__dirname, '..', 'uploads'); // local fallback
+const isProd = process.env.NODE_ENV === 'production';
 
-const PUBLIC_BASE = process.env.UPLOAD_PUBLIC_URL || '/uploads';
+// In dev: oldvine_cms/client/public
+const devPublicRoot = path.join(__dirname, '../../client/public');
+
+// On server: nginx serves /uploads from /var/www/oldvine/uploads (matches current nginx config)
+const uploadsDir =
+  process.env.UPLOADS_DIR ||
+  (isProd ? '/var/www/oldvine/uploads' : path.join(devPublicRoot, 'uploads'));
 
 // Ensure uploads directory exists
-if (!fs.existsSync(UPLOAD_DIR)) {
-  fs.mkdirSync(UPLOAD_DIR, { recursive: true });
+if (!fs.existsSync(uploadsDir)) {
+  fs.mkdirSync(uploadsDir, { recursive: true });
 }
 
+const safeBaseName = (name) =>
+  String(name || 'file')
+    .toLowerCase()
+    .replace(/\.[^/.]+$/, '') // remove extension
+    .replace(/[^a-z0-9]/g, '-')
+    .replace(/-+/g, '-')
+    .replace(/^-|-$/g, '');
+
+const pickOutput = (mimetype) => {
+  if (mimetype === 'image/png') return { ext: '.png', fmt: 'png' };
+  if (mimetype === 'image/webp') return { ext: '.webp', fmt: 'webp' };
+  // default jpeg for jpg/jpeg/gif/others
+  return { ext: '.jpg', fmt: 'jpeg' };
+};
+
 // Configure multer for file upload
 const storage = multer.diskStorage({
-  destination: (req, file, cb) => {
-    cb(null, UPLOAD_DIR);
-  },
+  destination: (req, file, cb) => cb(null, uploadsDir),
   filename: (req, file, cb) => {
     const uniqueSuffix = Date.now() + '-' + Math.round(Math.random() * 1e9);
-    const ext = path.extname(file.originalname).toLowerCase() || '.jpg';
-    const name = path
-      .basename(file.originalname, ext)
-      .replace(/[^a-z0-9]/gi, '-')
-      .toLowerCase()
-      .replace(/-+/g, '-')
-      .replace(/(^-|-$)/g, '');
-
-    cb(null, `${name || 'image'}-${uniqueSuffix}${ext}`);
+    const base = safeBaseName(file.originalname);
+    const { ext } = pickOutput(file.mimetype);
+    cb(null, `${base || 'upload'}-${uniqueSuffix}${ext}`);
   },
 });
 
 const fileFilter = (req, file, cb) => {
-  // Accept images only
-  if (file.mimetype && file.mimetype.startsWith('image/')) {
-    cb(null, true);
-  } else {
-    cb(new Error('Only image files are allowed'), false);
-  }
+  if (file.mimetype && file.mimetype.startsWith('image/')) return cb(null, true);
+  cb(new Error('Only image files are allowed'), false);
 };
 
 const upload = multer({
   storage,
   fileFilter,
-  limits: {
-    fileSize: 10 * 1024 * 1024, // 10MB limit
-  },
+  limits: { fileSize: 10 * 1024 * 1024 }, // 10MB
 });
 
-const optimizeImageInPlace = async (filePath, ext) => {
-  const lowerExt = (ext || '').toLowerCase();
-
-  // GIF: skip optimization (sharp may drop animation)
-  if (lowerExt === '.gif') return;
-
-  const tmpPath = filePath + '.tmp';
-
-  const pipeline = sharp(filePath)
-    .rotate()
-    .resize(1920, 1080, {
-      fit: 'inside',
-      withoutEnlargement: true,
-    });
-
-  if (lowerExt === '.png') {
-    await pipeline.png({ compressionLevel: 9 }).toFile(tmpPath);
-  } else if (lowerExt === '.webp') {
-    await pipeline.webp({ quality: 85 }).toFile(tmpPath);
-  } else {
-    // jpg/jpeg + anything else
-    await pipeline.jpeg({ quality: 85 }).toFile(tmpPath);
-  }
-
-  fs.renameSync(tmpPath, filePath);
-};
-
 // @route   POST /api/upload
 // @desc    Upload single or multiple images
 // @access  Private (Admin)
 router.post('/', adminAuth, upload.array('images', 10), async (req, res) => {
   try {
     if (!req.files || req.files.length === 0) {
-      return res.status(400).json({
-        success: false,
-        message: 'No files uploaded',
-      });
+      return res.status(400).json({ success: false, message: 'No files uploaded' });
     }
 
     const uploadedFiles = await Promise.all(
       req.files.map(async (file) => {
         try {
-          const ext = path.extname(file.filename);
-          await optimizeImageInPlace(file.path, ext);
+          const tmpPath = `${file.path}.opt`;
+          const { fmt } = pickOutput(file.mimetype);
+
+          let img = sharp(file.path).resize(1920, 1080, {
+            fit: 'inside',
+            withoutEnlargement: true,
+          });
+
+          if (fmt === 'png') img = img.png({ compressionLevel: 9 });
+          else if (fmt === 'webp') img = img.webp({ quality: 85 });
+          else img = img.jpeg({ quality: 85 });
+
+          await img.toFile(tmpPath);
+
+          fs.unlinkSync(file.path);
+          fs.renameSync(tmpPath, file.path);
 
           return {
             filename: file.filename,
             originalName: file.originalname,
-            url: `${PUBLIC_BASE}/${file.filename}`,
+            url: `/uploads/${file.filename}`,
             size: fs.statSync(file.path).size,
             mimeType: file.mimetype,
             uploadedAt: new Date(),
           };
-        } catch (error) {
-          console.error('Error processing image:', error);
+        } catch (err) {
+          console.error('Error processing image:', err);
           return {
             filename: file.filename,
             originalName: file.originalname,
-            url: `${PUBLIC_BASE}/${file.filename}`,
+            url: `/uploads/${file.filename}`,
             size: file.size,
             mimeType: file.mimetype,
             uploadedAt: new Date(),
@@ -124,91 +110,51 @@ router.post('/', adminAuth, upload.array('images', 10), async (req, res) => {
       })
     );
 
-    res.json({
-      success: true,
-      message: 'Files uploaded successfully',
-      data: { files: uploadedFiles },
-    });
+    res.json({ success: true, message: 'Files uploaded successfully', data: { files: uploadedFiles } });
   } catch (error) {
     console.error('Upload error:', error);
-    res.status(500).json({
-      success: false,
-      message: error.message || 'Error uploading files',
-    });
+    res.status(500).json({ success: false, message: error.message || 'Error uploading files' });
   }
 });
 
 // @route   GET /api/upload/list
-// @desc    Get list of uploaded files
-// @access  Private (Admin)
 router.get('/list', adminAuth, async (req, res) => {
   try {
-    const files = fs.readdirSync(UPLOAD_DIR);
+    const files = fs.readdirSync(uploadsDir);
 
     const fileList = files
-      .filter((file) => !file.startsWith('.'))
+      .filter((f) => !f.startsWith('.'))
       .map((filename) => {
-        const filePath = path.join(UPLOAD_DIR, filename);
+        const filePath = path.join(uploadsDir, filename);
         const stats = fs.statSync(filePath);
-
-        return {
-          filename,
-          url: `${PUBLIC_BASE}/${filename}`,
-          size: stats.size,
-          uploadedAt: stats.mtime,
-        };
+        return { filename, url: `/uploads/${filename}`, size: stats.size, uploadedAt: stats.mtime };
       })
       .sort((a, b) => b.uploadedAt - a.uploadedAt);
 
-    res.json({
-      success: true,
-      data: { files: fileList, total: fileList.length },
-    });
+    res.json({ success: true, data: { files: fileList, total: fileList.length } });
   } catch (error) {
     console.error('List files error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error listing files',
-    });
+    res.status(500).json({ success: false, message: 'Error listing files' });
   }
 });
 
 // @route   DELETE /api/upload/:filename
-// @desc    Delete an uploaded file
-// @access  Private (Admin)
 router.delete('/:filename', adminAuth, async (req, res) => {
   try {
     const { filename } = req.params;
 
-    // Security check
     if (filename.includes('..') || filename.includes('/') || filename.includes('\\')) {
-      return res.status(400).json({
-        success: false,
-        message: 'Invalid filename',
-      });
+      return res.status(400).json({ success: false, message: 'Invalid filename' });
     }
 
-    const filePath = path.join(UPLOAD_DIR, filename);
-
-    if (!fs.existsSync(filePath)) {
-      return res.status(404).json({
-        success: false,
-        message: 'File not found',
-      });
-    }
+    const filePath = path.join(uploadsDir, filename);
+    if (!fs.existsSync(filePath)) return res.status(404).json({ success: false, message: 'File not found' });
 
     fs.unlinkSync(filePath);
-
-    res.json({
-      success: true,
-      message: 'File deleted successfully',
-    });
+    res.json({ success: true, message: 'File deleted successfully' });
   } catch (error) {
     console.error('Delete file error:', error);
-    res.status(500).json({
-      success: false,
-      message: 'Error deleting file',
-    });
+    res.status(500).json({ success: false, message: 'Error deleting file' });
   }
 });